fix(Terraform): Failing checks due to parsing error CKV_GCP_54 & CKV_GCP_57 Issue 7033

[andrewkaldani30]

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

CKV_GCP_54 & CKV_GCP_57 checks are failing with TypeError: 'int' object is not subscriptable on flags = [{key: flag[key][0] for key in flag} for flag in flags]
failing with a cdk.tf.json file

We are not parsing the databse_flags object properly. This just grabs the name and value of each flag and appends to a new array which then we set flags to. This is te format checkov expects. I believe the errors comes from __startswith and __endswith being part of the flags list in the dict.

Ran unit tests for both the checks and they still pass and ran locally with a cdk.tf.json file to make sure databse_flags is parsed properly.

Fixes # 7033

Fix

How does someone fix the issue in code and/or in runtime?
Running checkov on a file that contains google_sql_database_instance leads to these errors I just went to the file where it errored and added the code in the pr.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• [] I have made corresponding changes to the documentation
• I have added tests that prove my feature, policy, or fix is effective and works
• New and existing tests pass locally with my changes

---

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Modifies the parsing of database flags in Google Cloud PostgreSQL checks to handle different data structures. Updates the GoogleCloudPostgreSqlLogLockWaits and GoogleCloudPostgreSqlLogMinDuration classes to correctly process the database_flags object, addressing a TypeError issue with CDK-generated Terraform JSON files.

Latest Contributors(2)

User	Commit	Date
rotemavni	fix-terraform-Handle-m...	September 28, 2022
losisin	fix-terraform-gcp-post...	September 05, 2022

This pull request is reviewed by Baz. Join @andrewkaldani30 and the rest of your team on (Baz).

[andrewkaldani30]

bump on this -- we would like to use google sql checks