-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure lookupDestinationPath
will handle relative path
#123
Conversation
Changes seem good, can you look into failing windows CI?
|
@rwjblue It is because of nodejs bug. nodejs/node#30538 |
I see. We should still have a passing CI in this repo before moving forward. Why don't we work around the issue? |
@SparshithNR - I'd really like to get this fixed, can you take a look at making it at least pass? |
Sorry, @rwjblue for not looking into it. I will make sure I will put some time to get some workaround if possible and update my progress EOD. |
Sorry looks like it is still failing |
Merged the work around #124, can you rebase? |
1. Let lookupDestinationPath handle the destDir and getDestinationPath 2. added test case
dcb1f95
to
219a262
Compare
Rebased and updated the PR. |
lookupDestinationPath
will handle relative path
Addressing [3.0.1] destDir not respected #122