preserve whitespace in svg text elements, when used in a reactor window

[schanzer]

(addresses #573)

[blerner]

This seems like the wrong fix to me, or at least, is too stringent. I suspect you want white-space: pre-wrap, since you want text to look like well-formatted text, not necessarily code. And what you likely really wanted was multiple lines of text, so you want to the white-space option that preserves linebreaks but in other respects formats text as text, hence pre-wrap.

[schanzer]

I want a string to render as a TEXT node within an SVG exactly as it would render in Pyret using text. No line wrapping. (although it would be pretty cool if Pyret supported line wrapping someday!)

[schanzer]

@blerner unfortunately, making this selector more restrictive is quite difficult!

Google Charts has total control over the DOM structure of a chart, and doesn't provide any helpful nodes, classes or ids that would let us identify this specific text. The best we can do is walk the DOM:

.ui-widget-content svg > g:nth-child(2) > text { white-space: pre; }

This works for our use-case, and from spot-checking all of our charts this causes no problems. But if Google ever changes their DOM tree, this will be yet another thing that breaks.

If this doesn't leave you feeling good about the PR, close it -- our userland workaround is good enough.

[blerner]

When you generate labels, are they strings, or can they be DOM nodes? If the latter, then generate <span class="our-specific-tag">{the string label}</span>, so you can trigger off of that...

[schanzer]

They're just strings. Google's API gives us only very primitive options