Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traffic advice: allow servers to specify a fraction #27

Merged
merged 1 commit into from
May 12, 2022

Conversation

jeremyroman
Copy link
Contributor

No description provided.

@jeremyroman
Copy link
Contributor Author

@domenic @buettner PTAL? This more or less just codifies the "fraction X means do only X of the stuff", since from what I've heard it seems that that approach has served us well so far.

I've made it so that it doesn't override "disallowed" (you need to pass the disallowed check and the fraction check). This is slightly different from how the Google EAP thing behaved -- it was overriding it on the basis that explicitly saying you wanted something for the EAP was more important than whatever else you were saying. This seems more natural in the long term.

@jeremyroman
Copy link
Contributor Author

(build fails because #26 hasn't landed yet -- and I haven't figured out how to do dependent pull requests on GitHub, if it's even possible)

@buettner
Copy link
Owner

This looks good to me. I think the fractional drop is all we need, and +1 to checking for disallow.

Copy link
Contributor

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Sorry for the delay in review.

@buettner buettner merged commit 6471584 into buettner:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants