Make unhandled overridable for React Native errors #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
PLAT-5595/unhandled-override-rn
branch
from
060522c to
fc2b6be
Compare
Android notifier sizes
Generated by 🚫 Danger |
tomlongridge
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Makes
event.unhandledoverridable in React Native errors passed from the JS layer. This allows users to decide whether specific errors apply to their stability score.Changeset
Calculate the original unhandled value from the
unhandledOverriddenflag, and pass it toSeverityReasonwhen constructing an event.Testing
Added unit tests to verify deserialization of event payload. PLAT-5595 will add E2E tests separately to the JS repo.