Fix calculation of durationInForeground when autoCaptureSessions is false #394
+70
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n autoCaptureSessions is false
The session tracker class failed to record activities entering the foreground when automatic tracking was disabled. This led to durationInForeground always showing as 0 in reports.
|
Can there be a test for the application sending an error while it is not in the foreground, and check that durationInForeground is set to zero |
…reground values when app has ex
|
thanks @Pezzah - I've added a mazerunner scenario that verifies the |
Pezzah
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
If
autoCaptureSessionsis set to false, theapp.durationInForegroundvalue always equals 0 in reports.Additionally, if the app is put into the background and then brought back into the foreground within a 30 second threshold, the
durationInForegroundvalue is not reset, and can be erroneously large.This changeset fixes these two issues.
Design
Please see the design doc for a detailed overview.
Tests
Added a mazerunner scenario to verify that
durationInForegroundis > 0 whenautoCaptureSessionsis false. Additionally, manual testing checked the following scenarios, for both potential values ofautoCaptureSessions:durationInForegrounddurationInForegroundfield