Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native): update bugsnag-cocoa #1048

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

djskinner
Copy link
Contributor

Updates the vendored bugsnag-cocoa to 6.1.4 primarily to incorporate the following fixes:

  • Copy the metadata observer list rather than mutating it directly.

Goal

So that react-native users can benefit from the copy the metadata observer list rather than mutating it directly bugfix found in bugsnag-cocoa 6.1.4

Changeset

  • Checkout out bugsnag-cocoa master branch as a sibling of bugsnag-js
  • Executed ./update-ios.sh in the packages/react-native directory
  • Committed the resulting changes

Testing

No manual testing has been performed.

Updates the vendored bugsnag-cocoa to 6.1.4 primarily to incorporate the following fixes:
- Copy the metadata observer list rather than mutating it directly.
@djskinner djskinner requested a review from a team as a code owner September 16, 2020 09:38
@bugsnagbot
Copy link
Collaborator

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against 66147ab

Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@djskinner djskinner merged commit bb03b2f into next Sep 16, 2020
@djskinner djskinner deleted the update-bugsnag-cocoa branch September 16, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants