-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite plugin-contextualize without domain #1924
Conversation
d69e437
to
9c49d75
Compare
9b06144
to
3874407
Compare
3874407
to
a72509f
Compare
103df37
to
b72bcd5
Compare
@@ -42,7 +42,7 @@ Scenario Outline: unhandled promise rejections are not reported when autoDetectE | |||
When I invoke the "<lambda>" lambda in "features/fixtures/simple-app" with the "events/<type>/promise-rejection.json" event | |||
Then the lambda response "errorMessage" equals "Error: yikes" | |||
And the lambda response "errorType" equals "Runtime.UnhandledPromiseRejection" | |||
And the lambda response "trace" is an array with 6 elements | |||
And the lambda response "trace" is an array with 5 elements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change here is that the line " at process.EventEmitter.emit (domain.js:483:12)"
is no longer present. This frame was being added due to the mere presence of require('domain')
in the contextualize plugin, which is part of the node notifier and therefore also instantiated in aws lambda.
Goal
Changeset
contextualize: (fn: () => void, onError: OnErrorCallback) => void
) but there are changes in behaviour.autoDetectErrors
andenabledErrorTypes.unhandledExceptions
. Now, the plugin will only capture unhandled exceptions if bothautoDetectErrors
andenabledErrorTypes.unhandledExceptions
are enabled.autoDetectErrors
andenabledErrorTypes.unhandledRejections
are enabled.Testing