V7: Ensure session interface matches spec #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djskinner
reviewed
Jan 7, 2020
packages/core/client.js
Outdated
| releaseStage: this._config.releaseStage, | ||
| version: this._config.appVersion, | ||
| type: this._config.appType | ||
| ...{ |
There was a problem hiding this comment.
What does this creation and spreading of an object literal achieve?
There was a problem hiding this comment.
ah this a mistake, I'll rework it
bengourley
force-pushed
the
v7-session-spec
branch
from
461b640 to
4d01726
Compare
bengourley
force-pushed
the
v7-session-spec
branch
from
4d01726 to
7a11f88
Compare
djskinner
approved these changes
Jan 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The session class and usage required a bit of tweaking now that the spec has settled down.