Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo SDK 38 support #890

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Expo SDK 38 support #890

merged 4 commits into from
Jul 6, 2020

Conversation

bengourley
Copy link
Contributor

Bumps the version of @react-native-community/netinfo as depended on by the upcoming SDK 38 of Expo.

Adds another branch to expo-cli to install a compatible version.

Note that the changes are not catastrophic in the bump from 5.5.0 -> 5.9.2. When running the current version of @bugsnag/expo against SDK 38 I was unable to produce a problem. However, there may be subtle bugs introduced by running v5.5.0 in JS against v5.9.2 native code bundled in Expo, so best to upgrade anyway.

@bengourley bengourley requested a review from djskinner June 23, 2020 11:08
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jun 23, 2020

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.54 kB 12.21 kB
After 39.54 kB 12.21 kB
± No change No change

Generated by 🚫 dangerJS against 40354f2

@bengourley bengourley merged commit 8bfd781 into next Jul 6, 2020
@bengourley bengourley deleted the bengourley/expo-sdk38-support branch July 6, 2020 11:04
@bengourley bengourley mentioned this pull request Jul 6, 2020
@imjoehaines imjoehaines mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants