Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a util package for length-delimited proto streams #3438

Closed
wants to merge 1 commit into from

Conversation

bduffany
Copy link
Member

@bduffany bduffany commented Feb 17, 2023

  • Add a package protodelim for consuming length-delimited proto streams. The name is inspired by the discussion here and also follows a similar naming convention to proto packages that deal with proto encodings (protojson, protowire, etc.)
  • Use the package in cli/printlog and server/util/protofile. Will also be used in Allow workflows to attach invocation artifacts #3386
    This should also reduce the amount of allocations in ReadProto (in protofile.go) since the new util reuses the same buffer across all unmarshal operations.

Version bump: Patch

@bduffany
Copy link
Member Author

Closing in favor of google.golang.org/protobuf/encoding/protodelim

@bduffany bduffany closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant