Add a util package for length-delimited proto streams #3438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protodelim
for consuming length-delimited proto streams. The name is inspired by the discussion here and also follows a similar naming convention to proto packages that deal with proto encodings (protojson
,protowire
, etc.)cli/printlog
andserver/util/protofile
. Will also be used in Allow workflows to attach invocation artifacts #3386This should also reduce the amount of allocations in
ReadProto
(inprotofile.go
) since the new util reuses the same buffer across all unmarshal operations.Version bump: Patch