Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci_runner] Save last used startup options to apply to cleanup commands #8653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maggie-lou
Copy link
Contributor

@maggie-lou maggie-lou commented Mar 14, 2025

During remote runner cleanup, we run a bazel command to check that the bazel lock isn't still held by the server, which would indicate some corruption on the machine.

However, if a customer runs a bazel command with startup options, because we don't apply these same startup options during our cleanup command, the bazel server ends up getting killed and restarted.

To work around this before we can figure out a different solution (tracked here), save the startup options from the last executed bazel command so we can apply them during cleanup

@maggie-lou maggie-lou force-pushed the startup_options_cleanup branch from 6fea919 to 8eeb9b2 Compare March 14, 2025 22:23
@maggie-lou maggie-lou force-pushed the startup_options_cleanup branch from 8eeb9b2 to 886d0d5 Compare March 14, 2025 23:39
@maggie-lou maggie-lou marked this pull request as ready for review March 14, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant