This repository was archived by the owner on Mar 1, 2024. It is now read-only.
Accessibility improvements: Button elements & a rel attributes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly to make these elements focusable, tabbable and clickable with a keyboard. Among other things, this change will improve accessibility for visually-impaired screenreader users, as well as users with reduced motor skills who might prefer to use a keyboard instead of a mouse.
Allowing developers to add the rel attribute will enable them to set rel="noopener noreferrer" on external links, especially those which open in a new tab. This helps mitigate a security vulnerability and potentially improves performance too. More info: - https://mathiasbynens.github.io/rel-noopener/ - https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/ - https://jakearchibald.com/2016/performance-benefits-of-rel-noopener/ Note that I've made this a string prop so developers can set whatever rel content they want, in case they want to set something else like rel="external" or rel="home" or whatever.
|
Hi @richardwestenra and thanks for this great PR! The code looks 👍 |
|
Thanks @FrancescoCioria! Note that I just noticed and fixed a missing comma. Hopefully that'll fix the broken build? |
that was definitely a mistake, but the CI is failing for other reasons and I don't think it's because of your PR... I'll look into it and see if I can fix it |
src/BannerContent.tsx
Outdated
| @@ -13,7 +13,8 @@ export type Props = { | |||
| link?: { | |||
| msg?: string, | |||
| url: string, | |||
| target?: '_blank' | '_self' | '_parent' | '_top' | 'framename' | |||
| target?: '_blank' | '_self' | '_parent' | '_top' | 'framename', | |||
| rel: string, | |||
There was a problem hiding this comment.
this should be optional, you can mark it as optional by adding the ? before the colon
There was a problem hiding this comment.
@FrancescoCioria good catch, thanks! I've just fixed it.
|
I tested and it looks fine 🎉 💅 |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
Description
<button>elements, either instead of a div, or as an added wrapper around the<i>icon element.This is mainly to make these elements focusable, tabbable and clickable with a keyboard. Among other things, this change will improve accessibility for visually-impaired screenreader users, as well as users with reduced motor skills who might prefer to use a keyboard instead of a mouse.
Notes