refactor: enable moduleResolution: bundler
to avoid @ts-ignore
#78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently
@electron-toolkit/tsconfig
[1] setsmoduleResolution
tonode
, and electron-store[2] is implemented based on conf[3]. Currentlyconf
exports types based onexports.types
:The current setup (
"moduleResolution": "node"
) cannot properly handle thetypes
field inexports
[4], so thattsc
to be unable to recognize these types.This PR enables
moduleResolution: bundler
[5] to remove all@ts-ignore
s.References
[1] https://github.com/alex8088/electron-toolkit/blob/master/packages/tsconfig/tsconfig.json#L10
[2] https://github.com/sindresorhus/electron-store/blob/main/package.json
[3] https://github.com/sindresorhus/conf/blob/main/package.json
[4] https://www.typescriptlang.org/tsconfig/#moduleResolution
[5] microsoft/TypeScript#51669, https://www.typescriptlang.org/docs/handbook/modules/theory.html#module-resolution-for-libraries