Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): only commit go changes when dirty #12722

Closed
wants to merge 1 commit into from

Conversation

korthout
Copy link
Member

@korthout korthout commented May 9, 2023

Description

The release dryrun failed because committing the changes to the go files failed because there were no changes to commit. We can easily prevent this by first checking whether the working tree is dirty.

Related issues

resolves an error encountered in https://github.com/camunda/zeebe/actions/runs/4921318914/jobs/8791034833#step:17:37

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

The release dryrun failed because committing the changes to the go files
failed because there were no changes to commit. We can easily prevent
this by first checking whether the working tree is dirty.
@korthout korthout requested a review from npepinpe May 9, 2023 11:26
@korthout korthout marked this pull request as ready for review May 9, 2023 11:27
@korthout
Copy link
Member Author

korthout commented May 9, 2023

Closing this in favor of:

@korthout korthout closed this May 9, 2023
@korthout korthout deleted the korthout-fix-release-dryrun branch May 9, 2023 13:46
github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant