-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove unnecessary commit for old go compat #12724
Conversation
Removes an unnecessary commit, as we don't use gocompat to generate a new compatibility file anymore, so we can simply drop this commit which has nothing to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @npepinpe ❤️
LGTM 👍
bors merge |
Build succeeded: |
/backport |
/backport Seems like this caused some errors for the backport action: https://github.com/camunda/zeebe/actions/runs/5066659671 |
/backport |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-12724-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-12724-to-stable/8.0
git checkout -b backport-12724-to-stable/8.0
ancref=$(git merge-base d6d93588789b8a1aee68a42bd8496543cf7bf483 08712b9789d68db77c77a9dec201a8ac2bf06ea8)
git cherry-pick -x $ancref..08712b9789d68db77c77a9dec201a8ac2bf06ea8 |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.1
git worktree add -d .worktree/backport-12724-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-12724-to-stable/8.1
git checkout -b backport-12724-to-stable/8.1
ancref=$(git merge-base d6d93588789b8a1aee68a42bd8496543cf7bf483 08712b9789d68db77c77a9dec201a8ac2bf06ea8)
git cherry-pick -x $ancref..08712b9789d68db77c77a9dec201a8ac2bf06ea8 |
Successfully created backport PR for |
12852: [Backport stable/8.2] build: remove unnecessary commit for old go compat r=npepinpe a=backport-action # Description Backport of #12724 to `stable/8.2`. relates to Co-authored-by: Nicolas Pepin-Perreault <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Description
Removes an unnecessary commit, as we don't use gocompat to generate a new compatibility file anymore, so we can simply drop this commit which has nothing to do.
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.