behave like can-stache-element to create a renderer from passed view #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmomberger-bitovi
requested changes
Jul 19, 2022
can-component.js
Outdated
| var viewName = string.capitalize( string.camelize(this.prototype.tag) )+"View"; | ||
| this.view = stache(viewName, this.view); | ||
|
|
||
| var viewName = string.capitalize( string.camelize(this.prototype.tag) )+"View"; |
There was a problem hiding this comment.
It looks like you're moving a var-type variable declaration out of a block, which is good, but I think we should still keep the computation of the viewName in the if block. Like this:
var viewName;
if (/* ... */) {
viewName = string.capitalize(string.camelize(this.prototype.tag) ) + "View";
// ...
}
bmomberger-bitovi
approved these changes
Jul 19, 2022
bmomberger-bitovi
added a commit
that referenced
this pull request
Feb 20, 2023
…che-ast-into-view adding a test for #372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR changes the behavior for creating a renderer.
in
can-stache-elementlink checks if the view is a function (renderer function).can-componentbehaved different. it checked for view beeing a string.https://github.com/canjs/can-component/blob/master/can-component.js#L383-L385
this is a breaking change, but the current documentation is still correct. so maybe this isn't worth to create a major release.
https://canjs.com/doc/can-component.prototype.view.html
this close #371