[DPE-3651] fix race condition with cluster auth #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-ratushnyy
previously approved these changes
Feb 29, 2024
Mehdi-Bendriss
previously approved these changes
Feb 29, 2024
MiaAltieri
dismissed stale reviews from Mehdi-Bendriss and dmitry-ratushnyy
via
eaf257d
dmitry-ratushnyy
approved these changes
Feb 29, 2024
Mehdi-Bendriss
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Flakey sharding tests would show that a cluster component would temporarily go into error due to unauthorised access in update_status, only for the for the unit to get resolved in the next hook execution
Reasoning
this is due to improper sync of passwords across cluster
Fixes #348
Solution
add a check in update status to notify the user why the cluster component is not yet connected