Add compatibility/arrow-functions-feature lint #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
requested changes
Jan 18, 2025
crates/linter/src/plugin/compatibility/rules/php74/arrow_functions_feature.rs
Outdated
Show resolved
Hide resolved
azjezz
reviewed
Jan 18, 2025
crates/linter/src/plugin/compatibility/rules/php74/arrow_functions_feature.rs
Outdated
Show resolved
Hide resolved
crates/linter/src/plugin/compatibility/rules/php74/arrow_functions_feature.rs
Outdated
Show resolved
Hide resolved
LinusU
force-pushed
the
lu-arrow-functions
branch
from
7d04960 to
8f02f85
Compare
|
Applied suggestions and rebased ✅ |
azjezz
added
Priority: Medium
LinusU
force-pushed
the
lu-arrow-functions
branch
from
8f02f85 to
3242699
Compare
|
Rebased again and ran |
azjezz
approved these changes
Jan 23, 2025
azjezz
added
Status: Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at writing a lint!
In order to test it out properly, the
MINIMUM_PHP_VERSIONneeds to be lowered toPHP73since arrow functions are available on PHP 7.4+. (note: there is currently an issue with "Null Coalesce Assignment Feature" that warns forphp_version = "7.4"see more info here: 95a84ce#r151496707)mago/src/consts.rs
Line 52 in dc32663
I have done that locally, and the lint seems to be working! 🎉