Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java.lang.ClassCastException with compose-runtime 1.4.0-alpha02 #641

Closed
alexvanyo opened this issue Nov 30, 2022 · 1 comment · Fixed by #650
Closed

java.lang.ClassCastException with compose-runtime 1.4.0-alpha02 #641

alexvanyo opened this issue Nov 30, 2022 · 1 comment · Fixed by #650
Labels
bug Something isn't working

Comments

@alexvanyo
Copy link
Contributor

Description
Paparazzi tests fail with java.lang.ClassCastException when using compose-runtime 1.4.0-alpha02

Steps to Reproduce

  • Update compose-runtime to 1.4.0-alpha02
  • Try to run a Paparazzi test

Additional information:
The internals of Recomposer.kt were recently updated, which changed the type of snapshotInvalidations from a val MutableList to a var MutableSet.

Paparazzi retrieves this field by reflection and casts it to a MutableList, which causes a java.lang.ClassCastException due to the update.
@alexvanyo alexvanyo added the bug Something isn't working label Nov 30, 2022
@alexvanyo alexvanyo mentioned this issue Dec 5, 2022
Closed
1 task
ZacSweers added a commit to ZacSweers/paparazzi that referenced this issue Dec 10, 2022
@ZacSweers
Fix ClassCastException in Compose 1.4.x
daf042f 
Resolves cashapp#641 in a backward-compatible way
@ZacSweers ZacSweers mentioned this issue Dec 10, 2022
Merged
@ZacSweers
Copy link
Contributor

Opened a PR with a backward-compatible fix here: #650

@JakeWharton JakeWharton mentioned this issue Jan 6, 2023
Closed
chrisbanes pushed a commit to chrisbanes/paparazzi that referenced this issue Jan 10, 2023
@ZacSweers @chrisbanes
Fix ClassCastException in Compose 1.4.x
2ae44eb 
Resolves cashapp#641 in a backward-compatible way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ClassCastException in Compose 1.4.x ZacSweers/paparazzi
2 participants
@ZacSweers @alexvanyo