Skip to content

props/page_header #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2021
Merged

props/page_header #39

merged 3 commits into from
Feb 2, 2021
+46 −13

Conversation

thompsongl
Copy link

  • Fix for center vs middle 😄
  • Start to some kind of "simulate with content" toggle

@thompsongl thompsongl mentioned this pull request Jan 29, 2021
Merged
9 tasks
@cchaos
Copy link
Owner

cchaos commented Jan 29, 2021 •
edited
Loading

Awesome thank you!

Fix for center vs middle 😄

🤦

@cchaos
Copy link
Owner

cchaos commented Jan 29, 2021

Is there also any way to get the rightSideContent one to work as well. That's a weird one because it's an array of nodes instead of just a straight up node.

@thompsongl
Copy link
Author

Is there also any way to get the rightSideContent one to work as well

Missed that one. Yep, I'll take a look

@cchaos
Copy link
Owner

cchaos commented Jan 29, 2021

I just pushed some updates I had been working on which caused conflicts here. But don't worry, I'll resolve those.

@thompsongl
Copy link
Author

Updated to allow for simulating rightSideContent

@cchaos cchaos merged commit b4df1a7 into cchaos:props/page_header Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thompsongl @cchaos