This repository was archived by the owner on Jan 25, 2022. It is now read-only.
Don't verify TLS [DEVOPS-627] #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjantop
reviewed
Oct 10, 2019
| @@ -1875,10 +1875,18 @@ PHP_REDIS_API int redis_sock_connect(RedisSock *redis_sock) | |||
| tv_ptr = &tv; | |||
| } | |||
|
|
|||
| php_stream_context *context = php_stream_context_alloc(); | |||
There was a problem hiding this comment.
Is it ok to just create a new context?
There was a problem hiding this comment.
Ideally we would pass in the context to \Redis, but in for our case explicitly creating a context should be good enough.
We also don't want to modify global PHP context for obvious reasons.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library doesn't support disabling peer (and peer hostname) verification, which is needed for our testing environments.
We should just disable this for all
\Redisinstances.