Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use GRPC from Swift Package Manager #1532

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AttilaTheFun
Copy link
Contributor

This is a re-do of #1019 which was closed when @brentleyjones 's PR merged, rebased onto the main branch.

This PR updates the GRPC examples to use a version of GRPC from RSPM. This is important because without this change developers would get compiler warnings or errors about duplicate symbols between the GRPC version included with rules_swift and GRPC pulled in through a Swift Package dependency.

I haven't been able to merge this PR previously because, before @brentleyjones merged this fix:
#1385

This is because the swift-atomics package (a dependency of grpc-swift) crashes on ubuntu without this flag.

@cgrindel
Copy link
Owner

These are moving to https://github.com/cgrindel/swift_gazelle_plugin. Should we apply the changes there and close this PR?

@AttilaTheFun
Copy link
Contributor Author

@cgrindel so I have already ported these over to swift_gazelle_plugin, but I think having at least one example demonstrating how to use SwiftProtobuf / grpc-swift from RSPM (rather than the one baked into rules_swift) is valuable. It doesn't need to use the gazelle plugin. Once we rip the gazelle plugin out of this repo, we can update the remaining examples to just use the rules_swift_package_manager repository rule + rules_swift directly.

@cgrindel
Copy link
Owner

OK. Can you run tidy to address the remaining failures?

@AttilaTheFun
Copy link
Contributor Author

@cgrindel I tried to clean it up, but these tidy checks are failing in CI but not on my local machine:
https://github.com/cgrindel/rules_swift_package_manager/actions/runs/13887594198/job/38854389683?pr=1532
I don't see an actual error message here. It just says that it failed.

I'm on macOS 15 and I see that it's failing on macOS 13 and ubuntu 22.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants