Test updated release/1.10-ci with prefast fixes #5281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had signed/unsigned mixups between the format string and the args.
Note that this includes functional changes to one implementation, as it could in some cases only set the getter or setter and leave the other uninitialized. There's also a couple other function annotation alignment fixes in this commit.
Unfortunately there's a good number of holes, which seem to be due to how the PREfast analysis of the locking works. Someone familiar with the mechanics may be able to do this with fewer suppressions.
A pre-defined function is added to the chakra etw header that does not initialize a buffer before passing it around. It looks ok, but the warning is in a file that we have limited control over. Here I disabled the warning for the whole included file, which seems like the closest we can scope it.
Due to template expansion this check can be redundant, so prefast warns on it.
Due to tightly scoped includes this file wasn't getting the warning disables that are used in the rest of the code base to handle a few situations that we accept (e.g. constant boolean logic, likely done due to flag handling).
PREfast checks for this now and decides that the pointer may be null, so the additional if statement protects against that.
PREfast complains if you add bools together; inserting the ternary expressions around them resolves this.
Unfortunately, this needs the suppression despire the assert. Here we copy things into a buffer, and PREfast thinks that we may write beyond the buffer bounds, despite the analysis asserts.
… Dev14 * Update Windows build matrix to use modern configuration Server 2016 + Dev15 and Legacy configuration Server 2012 R2 + Dev14 * Update script logic for forcing detection of a specific msbuild version.
|
@dotnet-bot test ci please |
|
@dotnet-bot test this please |
|
@dotnet-bot |
dilijev
changed the title
|
@Penguinwizzard when you update your prefast fix PR I'll update this PR to test them against the new CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5280 for CI update and fixes in #5272 by @Penguinwizzard