Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update iroh from 0.33.0 to 0.34.0 #6687

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Mar 20, 2025

No description provided.

@link2xt
Copy link
Collaborator Author

link2xt commented Mar 20, 2025

@dignifiedquire @flub What is the transition plan for raw keys? I enable tls_x509 for now, does it mean that it is not compatible with iroh clients that is not using tls_x509 and we have to keep this indefinitely, or can we drop it after a few releases and have a smooth transition?

EDIT: the answer is that tls_x509 is not compatible to tls_raw_public_keys, we just keep using tls_x509 and at some point (e.g. iroh 1.0 breaking compatibility anyway) we can switch to tls_raw_public_keys. DCBACKUP3 scheme will use raw keys.

@link2xt link2xt requested review from Hocuri and Septias March 24, 2025 18:00
@@ -35,6 +32,7 @@ skip = [
{ name = "http", version = "0.2.12" },
{ name = "loom", version = "0.5.6" },
{ name = "netlink-packet-route", version = "0.17.1" },
{ name = "netwatch", version = "0.3.0" },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've released a new patch version of portmapper. If you update that, the duplicate netwatch dependency should go away ✌️

@Hocuri
Copy link
Collaborator

Hocuri commented Mar 25, 2025

When I try to build this for Android, I get the following error:

$ ./ndk-make.sh
warning: Git tree '/home/user/Development/deltachat-android' is dirty
starting time: Tue Mar 25 12:24:31 CET 2025
Setting CARGO_TARGET environment variables.
Quick debug build that will produce a slower app. DO NOT UPLOAD THE APK ANYWHERE.
/home/user/Development/deltachat-android/jni
/home/user/Development/deltachat-android/jni/deltachat-core-rust
-- cross compiling to aarch64-linux-android (arm64) --
    Finished `dev` profile [optimized] target(s) in 0.32s
-- ndk-build --
[arm64-v8a] SharedLibrary  : libnative-utils.so
ld.lld: error: undefined symbol: preadv
>>> referenced by weak.rs:168 (std/src/sys/pal/unix/weak.rs:168)
>>>               std-993242cf06a7b510.std.5a80935b0be77383-cgu.0.rcgu.o:(_$LT$std..fs..File$u20$as$u20$std..os..unix..fs..FileExt$GT$::read_vectored_at::hab075818bf071fad) in archive jni/arm64-v8a/libdeltachat.a
>>> referenced by weak.rs:168 (std/src/sys/pal/unix/weak.rs:168)
>>>               std-993242cf06a7b510.std.5a80935b0be77383-cgu.0.rcgu.o:(_$LT$std..fs..File$u20$as$u20$std..os..unix..fs..FileExt$GT$::read_vectored_at::hab075818bf071fad) in archive jni/arm64-v8a/libdeltachat.a
>>> referenced by weak.rs:169 (std/src/sys/pal/unix/weak.rs:169)
>>>               std-993242cf06a7b510.std.5a80935b0be77383-cgu.0.rcgu.o:(_$LT$std..fs..File$u20$as$u20$std..os..unix..fs..FileExt$GT$::read_vectored_at::hab075818bf071fad) in archive jni/arm64-v8a/libdeltachat.a
>>> referenced 4 more times
>>> did you mean: readv
>>> defined in: /nix/store/r7v7as0l7a2asrh6m15avrmjsnf72spa-ndk-27-2-12479018-27.2.12479018/toolchains/llvm/prebuilt/linux-x86_64/bin/../sysroot/usr/lib/aarch64-linux-android/21/libc.so

ld.lld: error: undefined symbol: pwritev
>>> referenced by weak.rs:168 (std/src/sys/pal/unix/weak.rs:168)
>>>               std-993242cf06a7b510.std.5a80935b0be77383-cgu.0.rcgu.o:(_$LT$std..fs..File$u20$as$u20$std..os..unix..fs..FileExt$GT$::write_vectored_at::h8f497cf1b2446893) in archive jni/arm64-v8a/libdeltachat.a
>>> referenced by weak.rs:168 (std/src/sys/pal/unix/weak.rs:168)
>>>               std-993242cf06a7b510.std.5a80935b0be77383-cgu.0.rcgu.o:(_$LT$std..fs..File$u20$as$u20$std..os..unix..fs..FileExt$GT$::write_vectored_at::h8f497cf1b2446893) in archive jni/arm64-v8a/libdeltachat.a
>>> referenced by weak.rs:169 (std/src/sys/pal/unix/weak.rs:169)
>>>               std-993242cf06a7b510.std.5a80935b0be77383-cgu.0.rcgu.o:(_$LT$std..fs..File$u20$as$u20$std..os..unix..fs..FileExt$GT$::write_vectored_at::h8f497cf1b2446893) in archive jni/arm64-v8a/libdeltachat.a
>>> referenced 4 more times

ld.lld: error: undefined symbol: process_vm_writev
>>> referenced by nix.2ab134c738ef5a9-cgu.3
>>>               nix-ff443a8fa36385d6.nix.2ab134c738ef5a9-cgu.3.rcgu.o:(nix::sys::uio::process_vm_writev::h212ec9fb4e353a69) in archive jni/arm64-v8a/libdeltachat.a

ld.lld: error: undefined symbol: process_vm_readv
>>> referenced by nix.2ab134c738ef5a9-cgu.3
>>>               nix-ff443a8fa36385d6.nix.2ab134c738ef5a9-cgu.3.rcgu.o:(nix::sys::uio::process_vm_readv::h2396be9a216dccc4) in archive jni/arm64-v8a/libdeltachat.a
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [/nix/store/r7v7as0l7a2asrh6m15avrmjsnf72spa-ndk-27-2-12479018-27.2.12479018/build/core/build-binary.mk:661: obj/local/arm64-v8a/libnative-utils.so] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants