This repository was archived by the owner on Feb 23, 2022. It is now read-only.
SpecialText #437
Open
SpecialText #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralph-dev
suggested changes
Jan 22, 2022
ralph-dev
suggested changes
Jan 22, 2022
…Moved formatList into SpecialText.
…extLayoutProps. SpecialText takes onClick event.
|
Updated PR Description. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a demo:https://user-images.githubusercontent.com/50276107/150618022-1ec81aa5-4b5c-4ce0-a4f7-994dea69be35.mp4
Comparing to
HighlightedText, differences include:RemovedisSpecial,textProps,listProps,listItemArgs,ageRenamedlistItemsBodiestochildren.Treated as a single word rather than a list (i.e. no opacity feature).-
No longer passes explicitly passes propsNo longer usesClickableSmallText,MainTheme,TextLayoutProps,IDropdownProps,IDropdownItemProps,useEffect,useState.Changed SpecialText to be an atomic component.
Here is a demo of the SpecialText component.
SpecialText is a highlighted SmallText with onClick functionality.
Here is a WIP demo of the SpecialText component used with Dropdown in the VUI.
Currently replacing HighlightedText with SpecialText and cleaning up the VUI. Will get a PR out for review by today evening.