Skip to content

Fix Disable-BingSearch Windows release 2004 #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jnm2 opened this issue Jun 22, 2020 · 0 comments · Fixed by #438
Closed

Fix Disable-BingSearch Windows release 2004 #434

jnm2 opened this issue Jun 22, 2020 · 0 comments · Fixed by #438
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended

Comments

@jnm2
Copy link

jnm2 commented Jun 22, 2020 •
edited
Loading

2004 does not respect the previous registry key, but it respects a new one:

Version Key Name Value
Pre-2004 HKCU:\SOFTWARE\Microsoft\Windows\CurrentVersion\Search BingSearchEnabled 0
2004+ HKCU:\Software\Policies\Microsoft\Windows\Explorer DisableSearchBoxSuggestions 1

Source: https://www.lifehacker.com.au/2020/06/how-to-disable-bing-search-in-windows-10s-start-menu-2/ (personally verified twice)

The code that is out of date:

boxstarter/Boxstarter.WinConfig/Disable-BingSearch.ps1

Lines 11 to 18 in 981e114

$path = "HKCU:\SOFTWARE\Microsoft\Windows\CurrentVersion\Search"
if(!(Test-Path $path)) {
New-Item $path
}
New-ItemProperty -LiteralPath $path -Name "BingSearchEnabled" -Value 0 -PropertyType "DWord" -ErrorAction SilentlyContinue
Set-ItemProperty -LiteralPath $path -Name "BingSearchEnabled" -Value 0

(I started to help just as a heads up. At the point of submitting a PR for the edit I did through the GitHub UI, I saw https://github.com/chocolatey/boxstarter/blob/master/CONTRIBUTING.md too late to change the commit message. That document is a bit overwhelming. Feel free to use the branch if it's any actual help.)
@jnm2 jnm2 added 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue Improvement Issues that enhances existing functionality, or adds new features labels Jun 22, 2020
@pauby pauby added 4 - Done Code has been added to the repository, and has been reviewed by a team member Bug Issues where something has happened which was not expected or intended and removed 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue Improvement Issues that enhances existing functionality, or adds new features labels Aug 7, 2020
@pauby pauby changed the title Disable-BingSearch is out of date for the Windows 10 2004 update Fix Disable-BingSearch Windows release 2004 Aug 7, 2020
@pauby pauby mentioned this issue Aug 7, 2020
Merged
9 tasks
mwallner pushed a commit that referenced this issue Oct 11, 2020
@pauby
(GH-434) Fix disabling bing search for Win release 2004+ (#438)
a2f0e53
HolisticDeveloper pushed a commit to HolisticDeveloper/boxstarter that referenced this issue Oct 18, 2021
Merge branch 'master' of https://github.com/HolisticDeveloper/boxstarter
5f6559a 


* 'master' of https://github.com/HolisticDeveloper/boxstarter: (58 commits)
  Update chocolatey uninstall url
  Fix chocolatey links
  (chocolateyGH-446) Updates documentation with important info
  (chocolateyGH-443) Adds Windows Explorer item check box view Even though Boxstarter has existing functionality to modify Windows Explorer's settings, the existing functionality did not allow for user's to configure the "Use check boxes to select items" setting.  This commit adds that functionality to the existing set-windowsexploreroptions function.
  (chocolateyGH-451) more accurate regex
  (chocolateyGH-451) StopOnPackageFailiure not stripped without RebootCodes
  (release v2.13.0) Updated version numbers
  chocolateyGH-444 do not pass StopOnPackageFailure to choco
  Merge pull request from GHSA-rpgx-h675-r3jf
  (chocolateyGH-405) Fix package parameter handling (chocolatey#412)
  (chocolateyGH-434) Fix disabling bing search for Win release 2004+ (chocolatey#438)
  chocolateygh-435 docs for DelegateChocoSources
  (build) Replace direct usage of cinst
  (build) Pin all packages to specific version
  (build) Remove deprecated package
  (build) Make project files consistent
  (build) Pin to specific version of nuget.commandline
  (build) Remove VS import for web targets
  (build) Trying to fix AppVeyor build
  (doc) Update template
  ...
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-434) Fix disabling bing search for Win release 2004+
3 participants
@gep13 @jnm2 @pauby