Skip to content

(GH-336) Fix uninstall leftover shortcut #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 7, 2018
Merged

(GH-336) Fix uninstall leftover shortcut #372

merged 5 commits into from
Dec 7, 2018

Conversation

pauby
Copy link
Member

@pauby pauby commented Nov 25, 2018

Remove the start menu shortcut that is created by the Boxstarter.Chocolatey package.

@pauby pauby requested review from flcdrg, mwallner and gep13 November 28, 2018 10:47
mwallner
mwallner approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@mwallner mwallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flcdrg
Copy link
Member

flcdrg commented Nov 29, 2018

I am happy to merge this - just checking do we prefer squash and merge or rebase ?

@pauby
Copy link
Member Author

pauby commented Nov 30, 2018

@flcdrg I was told a Merge commit previously. @gep13 Can you confirm?

@gep13
Copy link
Member

gep13 commented Nov 30, 2018

@pauby @flcdrg personally, I normally always rebase PR's against the head of the target branch, and then merge into that branch (using --no-ff). The latter is what you will get by pressing the bug green "Merge pull request" button. I tend not to require a squashing of commits.

@pauby pauby mentioned this pull request Dec 7, 2018
Closed
@gep13 gep13 merged commit 13e2ebe into chocolatey:master Dec 7, 2018
@gep13
Copy link
Member

gep13 commented Dec 7, 2018

@pauby your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flcdrg flcdrg flcdrg approved these changes

@mwallner mwallner mwallner approved these changes

@gep13 gep13 Awaiting requested review from gep13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pauby @flcdrg @gep13 @mwallner