Skip to content

(doc) fix Uninstall-ChocolateyPath param #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Stunkymonkey
Copy link

@Stunkymonkey Stunkymonkey commented Apr 16, 2025

Description Of Changes

discovert a wrong parameter at Uninstall-ChocolateyPath -PathToUninstall

Motivation and Context

fixed it to Uninstall-ChocolateyPath -Path

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left-hand side)/
  • Menu structure has been updated

Related Issue

Fixes #

@Stunkymonkey Stunkymonkey marked this pull request as ready for review April 16, 2025 21:06
@Stunkymonkey Stunkymonkey force-pushed the fix-Uninstall-ChocolateyPath branch from b4a456e to 0e293c2 Compare April 16, 2025 21:06
@Stunkymonkey Stunkymonkey changed the title fix Uninstall-ChocolateyPath param (doc) fix Uninstall-ChocolateyPath param Apr 16, 2025
@pauby pauby requested a review from vexx32 April 22, 2025 10:07
Comment on lines +95 to +124
### -Confirm
Prompts you for confirmation before running the cmdlet.

```yaml
Type: SwitchParameter
Parameter Sets: (All)
Aliases: cf

Required: False
Position: Named
Default value: None
Accept pipeline input: False
Accept wildcard characters: False
```

### -WhatIf
Shows what would happen if the cmdlet runs. The cmdlet is not run.

```yaml
Type: SwitchParameter
Parameter Sets: (All)
Aliases: wi

Required: False
Position: Named
Default value: None
Accept pipeline input: False
Accept wildcard characters: False
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why these lines were changed, these should probably be taken out if we're getting odd whitespace changes in here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i created #1171 as a fix. It was applied because of the .editorconfig

@@ -32,7 +32,7 @@ Ensures that the given path is not present in the given type of PATH environment

### Example 1
```powershell
PS C:\> Uninstall-ChocolateyPath -PathToUninstall "$($env:SystemDrive)\tools\gittfs"
PS C:\> Uninstall-ChocolateyPath -Path "$($env:SystemDrive)\tools\gittfs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't disagree with this but I think we should probably just have two example sets, one for the canonical parameter name, and one for the alias. Cause it's not wrong, it's not just not most correct atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants