(#1952) Fix fact filter parsing #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
requested changes
Jan 9, 2023
ploubser
force-pushed
the
issue_1952
branch
2 times, most recently
from
0e09310 to
4e44c34
Compare
ripienaar
reviewed
Jan 10, 2023
ripienaar
reviewed
Jan 10, 2023
With the addition of GJson to describe fact values the old fact parser is no longer able to correctly identify facts vs operators in examples like `'storage.#(name=="vda").size'`. Here we rewrite the ParseFactFilterString function to no longer used complicated regular expressions. We will now correctly identify GJson facts and parse the filters correctly. In addition we're adding a wider range of tests for ParseFactFilterString so that we're covered if we were to add more fact filter functionality in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of GJson to describe fact values the old fact parser is no longer able to correctly identify facts vs operators in examples like
'storage.#(name=="vda").size'.Here we rewrite the ParseFactFilterString function to no longer used complicated regular expressions. We will now correctly identify GJson facts and parse the filters correctly.
In addition we're adding a wider range of tests for ParseFactFilterString so that we're covered if we were to add more fact filter functionality in the future.