Remove the connection timeout notification #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
========================================
+ Coverage 5.55% 5.56% +0.01%
========================================
Files 177 177
Lines 14215 14186 -29
Branches 310 310
========================================
Hits 790 790
+ Misses 13266 13237 -29
Partials 159 159 ☔ View full report in Codecov by Sentry. |
yannbf
approved these changes
Jan 17, 2025
valentinpalkovic
deleted the
valentin/remove-connection-timeout-notification
branch
|
🚀 PR was released in |
ghengeveld
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VTA had a built-in heartbeat check to determine whether the WS connection was alive. If it isn't, it shows a notification to the user. We are removing this check to build it into Storybook.
Relates to storybookjs/storybook#28258
Version
Published prerelease version:
v3.2.5-next.0Changelog
🐛 Bug Fix
Authors: 2