Skip to content
This repository was archived by the owner on Jan 6, 2022. It is now read-only.

Reorder and fix bug in maximise and minimise #177

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

greenfrogs
Copy link
Contributor

@greenfrogs greenfrogs commented Aug 16, 2021

There is currently a bug in MacOS emulation mode (right-align) with the green button minimising the application and yellow maximising the application. This corrects that issue and reorders them to be in the same order as Windows (minimise, maximise, close).

Currently (green minimises):
image

This PR (green maximises):
image

Fixes a bug in MacOS emulation mode with right alignment. Corrects yellow to minimise, green to maximise, and reorders them to be identical to Windows.
@quacksire
Copy link
Member

quacksire commented Aug 16, 2021

This isn't how to macOS stoplights work though... it's called macOS Emu for a reason

@greenfrogs
Copy link
Contributor Author

greenfrogs commented Aug 16, 2021

@child-duckling, I can put them back to be in the correct order for MacOS, however it then makes more sense if the middle (yellow) symbol minimises the application (rather than maximises).

In the original source code it says

/* Green - Maximize */
const greenStoplightOnClick = "ipcRenderer.send('minimize');";

That is why I had guessed it had been swapped, to mimic the order on Windows.

@greenfrogs
Copy link
Contributor Author

Side note, but there is some nice CSS implemented for adding the icons on hover for the stoplights here: https://gist.github.com/merqurio/4e17987b8515d44141e5952c55591869

@quacksire
Copy link
Member

That is why I had guessed it had been swapped, to mimic the order on Windows.

oh, I forgot that we made the right-align. You should be all set

@quacksire
Copy link
Member

Side note, but there is some nice CSS implemented for adding the icons on hover for the stoplights here: https://gist.github.com/merqurio/4e17987b8515d44141e5952c55591869

Noted

@quacksire quacksire merged commit 7fde941 into ciderapp:master Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants