This repository was archived by the owner on Jan 6, 2022. It is now read-only.
so basically fuck master branch yo #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…currently added work correctly.
…grated settings page.
Changed plugin class name to "AMEPluginHelper" Removed "OnSongChange" in favor of "OnPlaybackStateChanged"
Lyrics Translation
Removed call that opened devtools when lyrics are initialized
Reduces the amount of spaced used by lyric instrumental placeholder.
Further lyrics fixes
Added utils which contains functions used commonly across all files Created app-init.js which defined the functions in app.ame. Preferences moved into app-init.js New utils functions for pause, play, skip and previous Previously mentioned functions created in MusicKitInterop.js
Rewrite Musixmatch Lyrics Integration
Added AMJavaScript.getRequest("ameres://path/file", (content)=>{ // code here })
Moved settings from template literal to HTML file. In settingsPage.js it now uses AMJavaScript.getRequest to pull the html/preferences-main.html and html/preferences-footer.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
funny funny haha