Update default link to CDN to 4.13.0 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
f1ames
approved these changes
Nov 13, 2019
| @@ -51,6 +51,14 @@ describe( 'CKEditorComponent', () => { | |||
| } ); | |||
| } ); | |||
|
|
|||
| it( 'should have editorUrl pointing to 4.13.0 version', () => { | |||
There was a problem hiding this comment.
Since the CDN version will be updated with each release we will have to keep this test in sync. OTOH I don't see any particular reason that it is bad idea to have such test, so let's leave it and see how it works.
There was a problem hiding this comment.
Well, if there is any way to get the latest version of editor we could turn this into a variable instead of hardcoding, but I don't have any non-hacky idea for this right now 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping to current version of CKEditor 4.
Unit test attached.
Closes #59.