Skip to content

Introduce rotatable panels for ContextualBalloon #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oskarwrobel opened this issue May 6, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-ui#493
Closed

Introduce rotatable panels for ContextualBalloon #5505

oskarwrobel opened this issue May 6, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-ui#493
Assignees
Labels
package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@oskarwrobel
Copy link
Contributor

Now ContextualBalloon allows displaying one stack of views. It makes it possible to display views according to the one context. E.g. Balloon toolbar -> Link -> LinkForm.

It was not an issue because all features that using ContextualBalloon allows creating only one target element at the same node. Only one link is allowed on text, only on text alternative is allowed on the image, etc.

Now we need to deal with Inline Annotations that allows creating multiple targets elements at the same node. E.g. There could be a link, comment thread, and suggestion at the same node. The question is which view should be active after putting the selection to such a node? Or how to switch the view?

I propose to introduce rotatable panels with separate stacks. So instead of one stack, there could be multiple stacks. For each target element in the node, news stack is created and it is possible to switch between stacks (panels) using built-in navigation buttons.

When there is only one target element at the node it works as before.

@oskarwrobel oskarwrobel self-assigned this May 6, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-ui May 13, 2019

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
Feature: Introduced rotatable panels for `ContextualBalloon`. Closes https://github.com/ckeditor/ckeditor5-ui/issues/491.
pjasiun referenced this issue in ckeditor/ckeditor5-widget May 14, 2019
Internal: Aligned code to the latest ContextualBalloon API. Part of ckeditor/ckeditor5-ui#491.
pjasiun referenced this issue in ckeditor/ckeditor5-link May 14, 2019
Internal: Aligned code to the latest ContextualBalloon API. Part of ckeditor/ckeditor5-ui#491.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 24 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:ui labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
2 participants