Skip to content

Update params name for ScheduledTime::from #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

Update params name for ScheduledTime::from #708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce19886
chore: rename params name for ScheduledTime::from
und3fined Feb 15, 2025
2b889fd
chore: rename again for millis to in_millis
und3fined Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions worker/src/durable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,9 +700,9 @@ impl ScheduledTime {
}

impl From<i64> for ScheduledTime {
fn from(offset: i64) -> Self {
fn from(in_millis: i64) -> Self {
ScheduledTime {
init: ScheduledTimeInit::Offset(offset as f64),
init: ScheduledTimeInit::Offset(in_millis as f64),
}
}
}
Expand All @@ -718,9 +718,9 @@ impl From<DateTime<Utc>> for ScheduledTime {
}

impl From<Duration> for ScheduledTime {
fn from(offset: Duration) -> Self {
fn from(duration: Duration) -> Self {
ScheduledTime {
init: ScheduledTimeInit::Offset(offset.as_millis() as f64),
init: ScheduledTimeInit::Offset(duration.as_millis() as f64),
}
}
}
Expand Down