-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set service name at breadcrumbs #5716
feat: set service name at breadcrumbs #5716
Conversation
Signed-off-by: NaYeong,Kim <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
🎉 @WANZARGEN and @seungyeoneeee have been randomly selected as the reviewers! Please review. 🙏 |
@@ -52,6 +73,7 @@ onMounted(() => { | |||
|
|||
onUnmounted(() => { | |||
serviceDetailPageStore.initState(); | |||
gnbStore.setBreadcrumbs([]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does using gnbStore.setBreadcrumbs() forcibly override the breadcrumbs?
Breadcrumbs were originally designed to reflect the route-based structure — has this approach been deprecated?
gnbStore.setBreadcrumbs()를 사용하면 breadcrumbs를 강제로 치환하나요?
breadcrumbs는 라우트기반으로 반영되도록 설계되어 있는데, 이 방식은 폐기된건가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, the setting is based on routes, but if you need to replace a value (id) set by route-based settings with another value (name), you can apply it as described above.
아뇨, 기본 디폴트는 라우트 기반으로 셋팅되는데 라우트 기반으로 셋팅 되는 어떠한 값(id)를 치환해야하는 경우(name으로)에는 gnbStore.setBreadcrumbs()를 사용해서 적용할 수 있습니다.
Signed-off-by: NaYeong,Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Skip Review (optional)
style
,chore
,ci
,test
,docs
)Description (optional)
SSIA

Things to Talk About (optional)