Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Canary Step docs with more detailed example #550

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

sethboyles
Copy link
Member

@pspinrad Thanks for adding the initial docs. I've added some clarifications + examples on how exactly canary steps work

cc @Samze

@anita-flegg
Copy link
Contributor

Line 37 in this file is incomplete.
Someone may have been intending to add a reference, and didn't get back to it.

@anita-flegg anita-flegg requested a review from pspinrad March 21, 2025 14:34
@sethboyles
Copy link
Member Author

I'm guessing this was the intended doc https://docs.cloudfoundry.org/devguide/revisions.html#events ?

@sethboyles
Copy link
Member Author

@anita-flegg I updated that link. I didn't originally add that reference placeholder, so I'm not sure if that was then intent, but I think it works.

@anita-flegg anita-flegg merged commit 52ff476 into cloudfoundry:master Apr 1, 2025
1 check passed
@anita-flegg
Copy link
Contributor

Thanks, Seth. Looks good to me.

@anita-flegg
Copy link
Contributor

@pspinrad , this change might need to be cherry-picked to other branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants