ENH pickle classes and objects with __slots__ #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=========================================
+ Coverage 84.92% 85.1% +0.18%
=========================================
Files 1 1
Lines 577 584 +7
Branches 114 117 +3
=========================================
+ Hits 490 497 +7
Misses 63 63
Partials 24 24
Continue to review full report at Codecov.
|
pierreglaser
changed the title
pierreglaser
changed the title
pwais
approved these changes
Jan 14, 2019
| @@ -1310,6 +1310,35 @@ def g(x): | |||
|
|
|||
| self.assertEqual(f2.__annotations__, f.__annotations__) | |||
|
|
|||
| def test_instance_with_slots(self): | |||
There was a problem hiding this comment.
lg2m, thank you so much for taking this on!
pierreglaser
force-pushed
the
ENH_implement-slots-pickling
branch
from
9bf7281 to
878f1f6
Compare
pierreglaser
force-pushed
the
ENH_implement-slots-pickling
branch
from
878f1f6 to
381e267
Compare
pierreglaser
changed the title
ogrisel
approved these changes
Jan 15, 2019
ogrisel
approved these changes
Jan 17, 2019
|
I merged too quickly: we don't want to introduce a new dependency on six just for |
|
woops, didn't see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #225
Note that this this implementation will fail if the class
__slots__attribute is modified after the class creation.Choosing to handle this case would lead to complex and tedious code, and I am not even sure we can guess correctly the existence of slots in every single case.
In addition, choosing not to handle this is consistent with python's choice: stating the documetation of the stdlib's
copyreg._slotnamesfunction: