Skip to content

MNT mention #273 improvements in the changelog #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pierreglaser
Copy link
Member

Pickling classes - try for example with this script:

import cloudpickle


class A:
    pass


cloudpickle.dumps(A)

is now slightly faster (~10%) thanks to #273, so it is worth mentioning it in the changelog.

@pierreglaser pierreglaser force-pushed the mention-internal-refactoring-in-changelog branch from c4e9d17 to 1814520 Compare June 4, 2019 16:31
@pierreglaser
Copy link
Member Author

(Rebased)

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files           1        1           
  Lines         606      606           
  Branches      129      129           
=======================================
  Hits          555      555           
  Misses         31       31           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 725e2de...bf26d9b. Read the comment docs.

@ogrisel ogrisel merged commit f00e36e into cloudpipe:master Jun 5, 2019
@ogrisel
Copy link
Contributor

ogrisel commented Jun 5, 2019

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants