Skip to content

Don't include base class __slots__ in subclass construction #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2020
Merged

Don't include base class __slots__ in subclass construction #314

merged 5 commits into from
Feb 10, 2020

Conversation

pierreglaser
Copy link
Member

Fixes #311

@codecov
Copy link

codecov bot commented Oct 26, 2019 •
edited
Loading

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files           2        2           
  Lines         853      853           
  Branches      178      178           
=======================================
  Hits          793      793           
  Misses         37       37           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649fc59...8353372. Read the comment docs.

@pierreglaser pierreglaser changed the title TST add a test pickling class with inherited slots Don't include base class __slots__ in subclass construction Oct 26, 2019
@pierreglaser pierreglaser mentioned this pull request Oct 28, 2019
Closed
ogrisel
ogrisel approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel ogrisel merged commit 6e17ea9 into cloudpipe:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to pickle objects inherited from __slots__ in 1.2.2
2 participants
@pierreglaser @ogrisel