-
Notifications
You must be signed in to change notification settings - Fork 176
[NOMRG] test pickle5 + ray + refactored cloudpickle #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: jakirkham <[email protected]>
Tries to use `pickle5` for `pickle` if available on older Python versions.
reducer_override is no longer Python 3.8+-only code
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
===========================================
- Coverage 92.91% 82.50% -10.42%
===========================================
Files 2 3 +1
Lines 805 640 -165
Branches 164 134 -30
===========================================
- Hits 748 528 -220
- Misses 29 88 +59
+ Partials 28 24 -4
Continue to review full report at Codecov.
|
@jakirkham the failing test mentions a I'm trying to have EDIT: actually, I'm not sure it's about that. Seems like an interaction with a custom registered reducer implemented by ray. |
Alright. the |
Think that is fixed in
Yeah actually I knew the fix worked when I tried it, but I think more recent changes in PR ( #368 ) may have alleviated the underlying problem (as I had trouble reproducing the issue with an older |
Interesting. Thanks for surfacing that. I'll take another look and see if we can fix it. 🙂 |
merging this PR inside #370 should do the trick, as I had to fix the issue I mentioned to make the test pass :) |
Oh great! Thanks Pierre 😄 |
Closing as this is superseded by #370 |
This is a rebase of #370 with the newest changes in #368. in this PR,
ray
's downstream build should run succesfully.I'm making a temporary PR to not mess up #370 before I'm sure
ray
tests succeed.