-
Notifications
You must be signed in to change notification settings - Fork 176
Use string type annotations for Python 3.11 not 3.10 #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PEP 563 has been postponed to Python 3.11 https://mail.python.org/archives/list/[email protected]/thread/CLVXXPQ2T2LQ5MP2Y53VVQFCXYWQJHKZ/
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 4 4
Lines 668 668
Branches 136 136
=======================================
Hits 613 613
Misses 34 34
Partials 21 21 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe we want to explore the support for 3.7+ using the from __future__
pattern but I am not sure about the implications.
We probably need to update the CI config to include a nightly build to test explicitly the future 3.11 from the the main branch of Python and the 3.10 pre-release separately. |
|
At the time when I am writing this message, the change in the |
(Just making that labelling this PR using the |
PEP 563 has been postponed to Python 3.11
https://mail.python.org/archives/list/[email protected]/thread/CLVXXPQ2T2LQ5MP2Y53VVQFCXYWQJHKZ/
Another possibility is to revert this commit: 8a278a1
It's basically up to you to decide whether you want to be ready for Python 3.11 and keep this in the codebase for a year and a half.
And finally, the last possibility might be to use
from __future__ import annotations
to enable the new feature for Python 3.7+.