CI Skip publishing workflow on fork #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
commented
Mar 13, 2025
| @@ -1,4 +1,4 @@ | |||
| name: Publish Python 🐍 distribution 📦 to PyPI and TestPyPI | |||
| name: Publish cloudpickle 🥒 distribution 📦 to PyPI and TestPyPI | |||
There was a problem hiding this comment.
This workflow doesn't publish Python but cloudpickle :)
Result of a quick copy paste.
| @@ -30,10 +32,11 @@ jobs: | |||
| with: | |||
| name: python-package-distributions | |||
| path: dist/ | |||
| retention-days: 1 | |||
There was a problem hiding this comment.
by defaults artifacts are kept 90 days. For this workflow we only need them during the workflow run and 1 day is the minimum
ogrisel
approved these changes
Mar 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
===========================================
- Coverage 96.34% 84.73% -11.62%
===========================================
Files 3 2 -1
Lines 575 570 -5
Branches 121 102 -19
===========================================
- Hits 554 483 -71
- Misses 11 69 +58
- Partials 10 18 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomMoral
pushed a commit
to tomMoral/cloudpickle
that referenced
this pull request
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow should not run on forks and is annoying because github sends a notification each time you push to fork to tell you that it failed.