Skip to content

feat: Batch resources into a single record on source side #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 68 commits into from
Jun 20, 2024

Conversation

candiduslynx
Copy link
Contributor

No description provided.

@candiduslynx candiduslynx requested a review from disq April 22, 2024 12:51
Copy link

github-actions bot commented Apr 22, 2024

⏱️ Benchmark results

  • Glob-8 ns/op: 93.08

Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs a better PR title

Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could we debug logs on when do the flushes similar to the destination batcher logs we have?

Can be done in a follow up PR since the batching is disabled by default

@kodiakhq kodiakhq bot merged commit f86dcb5 into main Jun 20, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the feat/batch-source branch June 20, 2024 17:36
kodiakhq bot pushed a commit that referenced this pull request Jun 20, 2024
🤖 I have created a release *beep* *boop*
---


## [4.46.0](v4.45.6...v4.46.0) (2024-06-20)


### Features

* Batch resources into a single record on source side ([#1642](#1642)) ([f86dcb5](f86dcb5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants