-
Notifications
You must be signed in to change notification settings - Fork 25
feat: Batch resources into a single record on source side #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⏱️ Benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs a better PR title
1d39a0f
to
597d2f6
Compare
5fbbecc
to
ef5fb62
Compare
3a6d2f6
to
374ff0c
Compare
f01a1ff
to
7d1ef4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, could we debug logs on when do the flushes similar to the destination batcher logs we have?
Can be done in a follow up PR since the batching is disabled by default
8a99774
to
85e8963
Compare
🤖 I have created a release *beep* *boop* --- ## [4.46.0](v4.45.6...v4.46.0) (2024-06-20) ### Features * Batch resources into a single record on source side ([#1642](#1642)) ([f86dcb5](f86dcb5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
No description provided.