fix: Use clear for mixed batch writer
#1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
requested review from
yevgenypats,
hermanschaaf and
erezrokah
as code owners
⏱️ Benchmark results
|
erezrokah
approved these changes
Apr 22, 2024
erezrokah
requested changes
Apr 22, 2024
|
alt approach: to add |
erezrokah
approved these changes
Apr 22, 2024
disq
approved these changes
Apr 22, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
🤖 I have created a release *beep* *boop* --- ## [4.39.1](v4.39.0...v4.39.1) (2024-04-22) ### Bug Fixes * Fix link to billing page ([#1643](#1643)) ([ca216b6](ca216b6)) * Use `clear` for mixed batch writer ([#1645](#1645)) ([07945ac](07945ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue with
capused onnilslice introduced in #1553