Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a plot for visualizing all states of PRs #74

Merged
merged 0 commits into from
Aug 21, 2018

Conversation

andrius-k
Copy link
Contributor

Added a plot that shows all 3 states of Pull Requests (Approved, Pending and Rejected). It is accessible here http://cms-sw.github.io/stats/pr-states.html

@andrius-k
Copy link
Contributor Author

Hi,

Is there any problem with this PR? Otherwise, would it be possible to merge it?

@gudrutis
Copy link
Contributor

gudrutis commented Aug 17, 2018

We were not expecting new improvements in this repo - we used it mostly to dump JSON files for fronted.

Anyway, this PR is in mess now - 250+ commits and it has a merge conflict. Could you clean it up? I don't know how you managed to make cmsbuild to push to your fork...

@andrius-k
Copy link
Contributor Author

Hi,

Bot didn't commit to my branch. Apparently bot removed commits from the master after I submitted this PR and therefore my PR contains all of them right now. I will try to fix this.

In general I just added one more page that uses the same JSON files as data to show more detailed statistics about PR reviewals which is important for us.

@andrius-k
Copy link
Contributor Author

Ok, using the magic of git I was able to fix this issue and now the PR is clean. If it is common for bot to remove commits maybe we should merge this as soon as possible.

@gudrutis gudrutis merged this pull request into cms-sw:master Aug 21, 2018
@gudrutis
Copy link
Contributor

I see, I never saw this kind of issue before. Probably this is one of our optimizations to keep repo size minimum. Anyway, I merged your PR and your changes are already visible. Enjoy.

@davidlange6
Copy link
Contributor

davidlange6 commented Aug 21, 2018 via email

@gudrutis
Copy link
Contributor

Maybe it is not best to piggy-back on old PR, but I just wanted to let you know that I created I separate branch just for this repo's code. I suggest to
make all new commits/PR's bassed on that branch and then merge it to master.

cmsbuild pushed a commit that referenced this pull request Aug 26, 2018
Added a plot for visualizing all states of PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants