Move openapi build logic out of constructor #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnizzardini
deleted the
issue/454-move-openapi-build-logic-out-of-constructor
branch
cnizzardini
added a commit
that referenced
this pull request
Jan 11, 2024
* initial version 3 branch * Remove deprecated code (#426) Removes all methods, properties etc. and related documentation that was marked deprecated in 2.x * WIP * convert attribute properties to readonly where possible + phpstan fixes * add constant * doc updates * update docs * Move openapi build logic out of constructor (#469) * Move openapi build logic out of constructor #454 * set phptsan to version ^1.8.5 to resolve false-positives * update readme * Conditional pretty print #472 * Resolve deprecations and notices (#470) * Resolves notices * Reduce cyclomatic compexity * Remove non-executed code and increase coverage for Commands * Replace depreacted Router::scope with RouteBuilder->scope * Update github action descriptions * merge v2.5 into v3 (#483) * add php 8.2 ci matrix * Fixture Upgrade for cake 5 compat. * cleanup test bootstrap file * fixes broken tests * debug * debug * debug * debug * debug * Support CakePHP 5 dev branch (#516) Adds support for cakephp 5 and other necessary dependencies. * Require CakePHP 5 for version 3 (#530) * Merge master to v3 (#532) Merge v2.5.8 changes * update deps and fix static analysis warnings (#535) * small readme updates * upgrade to latest swaggerui and redocly --------- Co-authored-by: Chris Nizzardini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #454
The
buildmethod must now be called on Swagger to build the OpenAPI array. This resolves performance issues and removes a bad practice of executing heavy logic in constructors.Example: