Msaa on rt [DO NOT MERGE] #13856
Open
Msaa on rt [DO NOT MERGE] #13856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -55249,8 +55249,9 @@
width: number;
height: number;
renderPassInfo: gfx.RenderPassInfo;
swapchain?: gfx.Swapchain;
+ sampleCount?: gfx.SampleCount;
}
/**
* @en The render window represents the render target, it could be an off screen frame buffer or the on screen buffer.
* @zh 渲染窗口代表了一个渲染目标，可以是离屏的帧缓冲，也可以是屏幕缓冲
@@ -57675,8 +57676,9 @@
name?: string;
width: number;
height: number;
passInfo?: gfx.RenderPassInfo;
+ sampleCount?: gfx.SampleCount;
}
export interface _cocos_asset_asset_manager_cache__ICache<T> {
add(key: string, val: T): T;
get(key: string): T | undefined | null;
@@ -58988,8 +58990,12 @@
glCurrentAttribLocs: boolean[];
texUnitCacheMap: Record<string, number>;
initialize(texUnit: number, bufferBindings: number, vertexAttributes: number): void;
}
+ export interface _cocos_gfx_webgl2_webgl2_gpu_objects__IWebGL2ResolveTexture {
+ glTexture: WebGLTexture | null;
+ dirty: boolean;
+ }
export interface _cocos_gfx_webgl2_webgl2_gpu_objects__IWebGL2GPUTexture {
type: gfx.TextureType;
format: gfx.Format;
usage: gfx.TextureUsage;
@@ -59001,8 +59007,9 @@
mipLevel: number;
samples: gfx.SampleCount;
flags: gfx.TextureFlags;
isPowerOf2: boolean;
+ resolve: _cocos_gfx_webgl2_webgl2_gpu_objects__IWebGL2ResolveTexture;
glTarget: GLenum;
glInternalFmt: GLenum;
glFormat: GLenum;
glType: GLenum;
|
|
@cocos-robot run test case |
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task DetailsNo task results found. |
star-e
reviewed
Dec 22, 2022
| #if CC_EDITOR | ||
| #if defined(CC_USE_GLES3) || defined(CC_USE_GLES2) | ||
| // by enabling this render target texture is mltisampled | ||
| static constexpr bool MSAA_RT{false}; |
There was a problem hiding this comment.
Shall we put them in namespace cc?
There was a problem hiding this comment.
sure, will add it in coming commit.
star-e
reviewed
Dec 22, 2022
| fbInfo.height = gpuFBO->gpuColorTextures.empty() ? dsWidth : std::min(fbInfo.height, dsHeight); | ||
| } | ||
|
|
||
| fbInfo.glFramebuffer = device->framebufferCacheMap()->getFramebufferByHash(gpuFBO); |
There was a problem hiding this comment.
will get by hash cause collision?
There was a problem hiding this comment.
Hash by GLES2/3Texture, in gfx thread there is no GFXAgent or GFXValidator get involved, it's safe if there's no placement new on GFXTexture. To make it more reliable we can hash glTarget/glTexture/glRenderBuffer additionally.
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
for reference, msaa on web with 1(NoAA) / 2(PerformanceAA) / 4(BalanceAA) / 8(QualityAA) samples: |
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
Known issue: if hdr is active, forwardstege use rgba16f as render texture, which is not copyable to swapchain (rgba8unorm) on android.
while this is not required on gl32, we are loading gl32 on windows: |
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
@hana-alice, Please check the result of
Task Details
|
|
test-case: cocos/cocos-test-projects#746 when rendertexture samplecount is not SampleCount::ONE:
above only occurs in msaa camera. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for multipass msaa support. we have msaa but only works on single pass(otherwise GL rendering issues).
Changelog
now just create an additional msaa texture and implicilty replace the origin attachment slot in framegraph, and disable frabmebuffermsaa extension on windows.
Continuous Integration
This pull request:
Compatibility Check
This pull request: