Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-typescript): adjust logic #975

Merged
merged 18 commits into from
Mar 21, 2025
Merged

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Mar 10, 2025

This PR includes:

  • docs
  • plugin exports
  • demo usage - @matejchalk any idea how we can use it best on our code?

Followup:

@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label Mar 10, 2025
Copy link

github-actions bot commented Mar 10, 2025

Code PushUp

😟 Code PushUp report has regressed – compared current commit 015b9d7 with previous commit b03db63.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 55 🔴 39 ↓ −16
Code coverage 🟢 90 🟢 90 ↓ −0.1
Type Safety n/a (*) 🟢 100 n/a (*)
Miscellaneous n/a (*) 🟢 100 n/a (*)
Security 🟡 67 🟡 67
Updates 🟡 81 🟡 81
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23

(*) New category.

👎 2 groups regressed, 👎 6 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 55 🔴 39 ↓ −16
Code coverage Code coverage metrics 🟢 90 🟢 90 ↓ −0.1

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.3 s 🟥 4.7 s ↑ +41.7 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟥 4.0 s ↑ +45.6 %
Lighthouse Speed Index 🟨 5.0 s 🟥 6.8 s ↑ +36.7 %
Lighthouse Total Blocking Time 🟥 3,070 ms 🟥 5,960 ms ↑ +94.4 %
Lighthouse Time to Interactive 🟥 13.1 s 🟥 13.7 s ↑ +4.9 %
Code coverage Line coverage 🟨 89.8 % 🟨 89.8 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 13.1 s 🟥 18.5 s ↑ +41.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,832 KiB 🟩 Total size was 1,828 KiB ↓ −0.3 %
Lighthouse JavaScript execution time 🟥 5.8 s 🟥 7.4 s ↑ +27.9 %
Lighthouse Max Potential First Input Delay 🟥 1,280 ms 🟥 2,480 ms ↑ +94.3 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 900 ms 🟥 Potential savings of 1,810 ms ↑ +100.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +4.9 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Server Backend Latencies 🟩 90 ms 🟩 140 ms ↑ +54.8 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 380 ms ↓ −3.6 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 20 ms ↓ −11.3 %
Lighthouse Avoid large layout shifts 🟩 0 🟩 1 layout shift found ↑ +∞ %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↑ +∞ %

578 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review March 10, 2025 19:11
@BioPhoton BioPhoton requested a review from matejchalk March 11, 2025 10:56
@github-actions github-actions bot added the 🔬 testing writing tests label Mar 19, 2025
@BioPhoton BioPhoton requested a review from matejchalk March 20, 2025 14:27
@BioPhoton BioPhoton requested a review from matejchalk March 20, 2025 14:47
@BioPhoton BioPhoton merged commit bf33ffa into main Mar 21, 2025
16 checks passed
@BioPhoton BioPhoton deleted the feature/ts-plugin-exports branch March 21, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants